From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 24 Sep 2018 13:22:25 +0000 (+0200)
Subject: security: Don't try to lock NULL paths
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=cd33eaa2513a143c47775777806ebb2e759c7617;p=libvirt.git

security: Don't try to lock NULL paths

It may happen that in the list of paths/disk sources to relabel
there is a disk source. If that is the case, the path is NULL. In
that case, we shouldn't try to lock the path. It's likely a
network disk anyway and therefore there is nothing to lock.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
---

diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 5aea386e7c..62442745dd 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_dac.c
@@ -216,7 +216,8 @@ virSecurityDACTransactionRun(pid_t pid ATTRIBUTE_UNUSED,
     for (i = 0; i < list->nItems; i++) {
         const char *p = list->items[i]->path;
 
-        if (virFileIsDir(p))
+        if (!p ||
+            virFileIsDir(p))
             continue;
 
         VIR_APPEND_ELEMENT_COPY_INPLACE(paths, npaths, p);