From: Daniel P. Berrangé <berrange@redhat.com>
Date: Tue, 18 Jun 2019 17:31:34 +0000 (+0100)
Subject: conf: fix leak of directory handle when loading network ports
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=cce545ddb6dfb3492e4d31a0e04e4ee4cb16cf93;p=libvirt.git

conf: fix leak of directory handle when loading network ports

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c
index 47c142998e..adf144fae2 100644
--- a/src/conf/virnetworkobj.c
+++ b/src/conf/virnetworkobj.c
@@ -1718,7 +1718,7 @@ virNetworkObjDeleteAllPorts(virNetworkObjPtr net,
                             const char *stateDir)
 {
     char *dir;
-    DIR *dh;
+    DIR *dh = NULL;
     struct dirent *de;
     int rc;
     int ret = -1;
@@ -1750,6 +1750,7 @@ virNetworkObjDeleteAllPorts(virNetworkObjPtr net,
 
     ret = 0;
  cleanup:
+    VIR_DIR_CLOSE(dh);
     return ret;
 }