From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 5 Feb 2018 13:05:05 +0000 (+0100)
Subject: util: bitmap: Note that shrinking the bitmap requires clearing of unused bits
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=cb775a51a0eb953635c8e35689b8b1f3cce0d381;p=libvirt.git

util: bitmap: Note that shrinking the bitmap requires clearing of unused bits

Note the fact that the unused portion of the last element in the bitmap
needs to be cleared, since we use functions which process only full-size
elements and don't really deal with individual bits.
---

diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c
index 82b1f76427..0cc5292d8c 100644
--- a/src/util/virbitmap.c
+++ b/src/util/virbitmap.c
@@ -45,6 +45,10 @@ struct _virBitmap {
     size_t nbits;
     size_t map_len;
     size_t map_alloc;
+
+    /* Note that code below depends on the fact that unused bits of the bitmap
+     * are not set. Any function decreasing the size of the map needs clear
+     * bits which don't belong to the bitmap any more. */
     unsigned long *map;
 };