From: Erik Skultety <eskultet@redhat.com>
Date: Tue, 3 May 2016 15:04:42 +0000 (+0200)
Subject: admin: Add a check to reject negative argument for number of typed params
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=ca0d45148d09b6712f7a9563d88a1befb585e88c;p=libvirt.git

admin: Add a check to reject negative argument for number of typed params

Since nparams can be technically negative, it is a good practice throughout
our code to check if nparams actually has a non-negative value. The same effect
would be achieved by converting our internal typed params serializer argument
to 'unsigned' type, but it definitely would not be the path of least resistance.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---

diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c
index a94f5dd1d3..4ad816b1fc 100644
--- a/src/libvirt-admin.c
+++ b/src/libvirt-admin.c
@@ -838,6 +838,7 @@ virAdmServerSetThreadPoolParameters(virAdmServerPtr srv,
 
     virCheckAdmServerReturn(srv, -1);
     virCheckNonNullArgGoto(params, error);
+    virCheckNonNegativeArgGoto(nparams, error);
 
     if (remoteAdminServerSetThreadPoolParameters(srv, params,
                                                  nparams, flags) < 0)