From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 11 Jul 2024 07:32:40 +0000 (+0200)
Subject: virt-host-validate: Drop extra "PASS"
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=c9fa43c48cdb1b8505929e3287975445f3004f32;p=libvirt.git

virt-host-validate: Drop extra "PASS"

If virt-host-validate is ran on a SEV-SNP capable machine, an
extra "PASS" is printed out. This is because
virHostValidateAMDSev() prints "PASS" and then returns 1
(indicating success) which in turn makes the caller
(virHostValidateSecureGuests()) print "PASS" again. Just drop the
extra printing in the caller and let virHostValidateAMDSev() do
all the printing.

Fixes: 1a8f646f291775d2423ce4e4df62ad69f06ab827
Resolves: https://issues.redhat.com/browse/RHEL-46868
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c
index a29a5b6d5f..591143c24d 100644
--- a/tools/virt-host-validate-common.c
+++ b/tools/virt-host-validate-common.c
@@ -488,11 +488,7 @@ int virHostValidateSecureGuests(const char *hvname,
             return VIR_VALIDATE_FAILURE(level);
         }
     } else if (hasAMDSev) {
-        int rc = virHostValidateAMDSev(hvname, level);
-
-        if (rc > 0)
-            virValidatePass();
-        return rc;
+        return virHostValidateAMDSev(hvname, level);
     }
 
     virValidateFail(level,