From: Nikolay Shirokovskiy Date: Fri, 9 Nov 2018 11:36:19 +0000 (+0300) Subject: qemu: don't log error for missing optional storage sources on start X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=c541177314f9472a9217add145d2038d57ac1876;p=libvirt.git qemu: don't log error for missing optional storage sources on start Because missing optional storage source is not error. The patch address only local files. Fixing other cases is a bit ugly. Below is example of error notice in log now: error: virStorageFileReportBrokenChain:427 : Cannot access storage file '/path/to/missing/optional/disk': No such file or directory Signed-off-by: Nikolay Shirokovskiy --- diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index e5b567228c..d061591f62 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6119,7 +6119,15 @@ qemuProcessPrepareHostStorage(virQEMUDriverPtr driver, if (!blockdev) virStorageSourceBackingStoreClear(disk->src); - if (qemuDomainDetermineDiskChain(driver, vm, disk, true) >= 0) + /* + * Go to applying startup policy for optional disk with nonexistent + * source file immediately as determining chain will surely fail + * and we don't want noisy error notice in logs for this case. + */ + if (qemuDomainDiskIsMissingLocalOptional(disk) && cold_boot) + VIR_INFO("optional disk '%s' source file is missing, " + "skip checking disk chain", disk->dst); + else if (qemuDomainDetermineDiskChain(driver, vm, disk, true) >= 0) continue; if (qemuDomainCheckDiskStartupPolicy(driver, vm, idx, cold_boot) >= 0)