From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 21 Sep 2011 18:55:04 +0000 (+0200)
Subject: PM / Suspend: Off by one in pm_suspend()
X-Git-Tag: v2.6.32.49~20
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=c4b16f7f222bb71d44a94a75f291d3fc2c9292b5;p=linux-pvops.git

PM / Suspend: Off by one in pm_suspend()

commit 528f7ce6e439edeac38f6b3f8561f1be129b5e91 upstream.

In enter_state() we use "state" as an offset for the pm_states[]
array.  The pm_states[] array only has PM_SUSPEND_MAX elements so
this test is off by one.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
index 6f10dfc2d3e9..40dd021779f9 100644
--- a/kernel/power/suspend.c
+++ b/kernel/power/suspend.c
@@ -293,7 +293,7 @@ int enter_state(suspend_state_t state)
  */
 int pm_suspend(suspend_state_t state)
 {
-	if (state > PM_SUSPEND_ON && state <= PM_SUSPEND_MAX)
+	if (state > PM_SUSPEND_ON && state < PM_SUSPEND_MAX)
 		return enter_state(state);
 	return -EINVAL;
 }