From: Jan Kiszka <jan.kiszka@web.de>
Date: Sat, 21 Jan 2012 13:43:07 +0000 (+0100)
Subject: qdev-property: Make bit property parsing stricter
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=c455d17c09f797055ec52afc25e8735c72d00ca0;p=qemu-xen-4.5-testing.git

qdev-property: Make bit property parsing stricter

By using strncasecmp, we allow for arbitrary characters after the
"on"/"off" string. Fix this by switching to strcasecmp.

Reviewed-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---

diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 02f0dae0b..ea3b2df35 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -40,9 +40,9 @@ static void qdev_prop_cpy(DeviceState *dev, Property *props, void *src)
 /* Bit */
 static int parse_bit(DeviceState *dev, Property *prop, const char *str)
 {
-    if (!strncasecmp(str, "on", 2))
+    if (!strcasecmp(str, "on"))
         bit_prop_set(dev, prop, true);
-    else if (!strncasecmp(str, "off", 3))
+    else if (!strcasecmp(str, "off"))
         bit_prop_set(dev, prop, false);
     else
         return -EINVAL;