From: Jim Meyering <meyering@redhat.com>
Date: Tue, 29 Apr 2008 14:25:19 +0000 (+0000)
Subject: tests: recognize more uses of strcmp.
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=c3626941c799db4966a4f49d292501ed7acfbb23;p=libvirt.git

tests: recognize more uses of strcmp.

* Makefile.maint (sc_prohibit_strcmp): Relax regexp.
---

diff --git a/ChangeLog b/ChangeLog
index f5e10e028e..4f2a301135 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -15,6 +15,9 @@ Tue Apr 29 09:46:00 EST 2008 Daniel P. Berrange <berrange@redhat.com>
 
 Tue Apr 29 15:20:12 CEST 2008 Jim Meyering <meyering@redhat.com>
 
+	Recognize more uses of strcmp.
+	* Makefile.maint (sc_prohibit_strcmp): Relax regexp.
+
 	Avoid "make syntax-check" failures.
 	* src/memory.c: Include "config.h".
 	Remove trailing blanks.
diff --git a/Makefile.maint b/Makefile.maint
index b864455b4b..ddf42bc689 100644
--- a/Makefile.maint
+++ b/Makefile.maint
@@ -91,7 +91,7 @@ sc_prohibit_atoi_atof:
 
 # Use STREQ rather than comparing strcmp == 0, or != 0.
 sc_prohibit_strcmp:
-	@grep -nE '! *str''cmp \(|\<str''cmp \([^)]+\) *=='		\
+	@grep -nE '! *str''cmp *\(|\<str''cmp *\([^)]+\) *=='		\
 	    $$($(VC_LIST_EXCEPT)) &&					\
 	  { echo '$(ME): use STREQ in place of the above uses of str''cmp' \
 		1>&2; exit 1; } || :