From: Philippe Mathieu-Daudé Date: Tue, 27 Jul 2021 14:24:31 +0000 (+0200) Subject: gitlab-ci: Fix 'when:' condition in OpenSBI jobs X-Git-Tag: qemu-xen-4.16.0-rc4~34^2~5 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=c217fd8e36a1d619956f550e8a39528a855de2f5;p=qemu-xen.git gitlab-ci: Fix 'when:' condition in OpenSBI jobs Jobs depending on another should not use the 'when: always' condition, because if a dependency failed we should not keep running jobs depending on it. The correct condition is 'when: on_success'. Fixes: c6fc0fc1a71 ("gitlab-ci.yml: Add jobs to build OpenSBI firmware binaries") Reported-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Reviewed-by: Willian Rampazzo Message-Id: <20210727142431.1672530-5-philmd@redhat.com> Signed-off-by: Thomas Huth --- diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml index d8a0456679..5e0a2477c5 100644 --- a/.gitlab-ci.d/opensbi.yml +++ b/.gitlab-ci.d/opensbi.yml @@ -6,14 +6,14 @@ - .gitlab-ci.d/opensbi.yml # or the Dockerfile is modified - .gitlab-ci.d/opensbi/Dockerfile - when: always + when: on_success - changes: # or roms/opensbi/ is modified (submodule updated) - roms/opensbi/* - when: always + when: on_success - if: '$CI_COMMIT_REF_NAME =~ /^opensbi/' # or the branch/tag starts with 'opensbi' - when: always + when: on_success - if: '$CI_COMMIT_MESSAGE =~ /opensbi/i' # or last commit description contains 'OpenSBI' - when: always + when: on_success docker-opensbi: extends: .opensbi_job_rules