From: Corey Minyard <cminyard@mvista.com>
Date: Wed, 6 Dec 2017 17:39:32 +0000 (-0600)
Subject: smbios:ipmi: Ignore IPMI devices with no fwinfo function
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=bfff1a6d42537acbb419388c542e3a95d66a15a4;p=people%2Fpauldu%2Fqemu.git

smbios:ipmi: Ignore IPMI devices with no fwinfo function

Not all devices have fwinfo (like the coming PCI one), so ignore
them if the their fwinfo function is NULL.

Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---

diff --git a/hw/smbios/smbios_type_38.c b/hw/smbios/smbios_type_38.c
index 0c08f282de..168b886647 100644
--- a/hw/smbios/smbios_type_38.c
+++ b/hw/smbios/smbios_type_38.c
@@ -94,6 +94,9 @@ static void smbios_add_ipmi_devices(BusState *bus)
             ii = IPMI_INTERFACE(obj);
             iic = IPMI_INTERFACE_GET_CLASS(obj);
             memset(&info, 0, sizeof(info));
+            if (!iic->get_fwinfo) {
+                continue;
+            }
             iic->get_fwinfo(ii, &info);
             smbios_build_one_type_38(&info);
             continue;