From: Alex Bennée <alex.bennee@linaro.org>
Date: Tue, 12 Nov 2019 15:08:15 +0000 (+0000)
Subject: tests/vm: make --interactive (and therefore DEBUG=1) unconditional
X-Git-Tag: qemu-xen-4.14.0~265^2~4
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=bcc388df07b8ac69660c2ad0200d4f242513e642;p=qemu-xen.git

tests/vm: make --interactive (and therefore DEBUG=1) unconditional

While the concept of only dropping to ssh if a test fails is nice it
is more useful for this to be unconditional. You usually just want to
get the build up and running and then noodle around debugging or
attempting to replicate.

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---

diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 91a9226026..0b8c1b2657 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -403,7 +403,7 @@ def main(vmcls):
     exitcode = 0
     if vm.ssh(*cmd) != 0:
         exitcode = 3
-    if exitcode != 0 and args.interactive:
+    if args.interactive:
         vm.ssh()
 
     if not args.snapshot: