From: Nikolay Shirokovskiy Date: Tue, 22 Mar 2016 13:56:37 +0000 (+0300) Subject: vz: fix disk order on load domain X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=bc281f7d7d194ad25855c3b83a565a81c5e9aa05;p=libvirt.git vz: fix disk order on load domain We want to report boot order in dumpxml for vz domains. Thus we want disks devices to be sorted in output compatible with boot ordering specification. So let's just use virDomainDiskInsert which makes appropriate sorting. Signed-off-by: Nikolay Shirokovskiy --- diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 49f39e8ee5..0c2cfa0e63 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -663,7 +663,7 @@ prlsdkAddDomainHardDisksInfo(vzConnPtr privconn, PRL_HANDLE sdkdom, virDomainDef if (prlsdkGetDiskInfo(privconn, hdd, disk, false, IS_CT(def)) < 0) goto error; - if (VIR_APPEND_ELEMENT(def->disks, def->ndisks, disk) < 0) + if (virDomainDiskInsert(def, disk) < 0) goto error; disk = NULL; @@ -706,7 +706,7 @@ prlsdkAddDomainOpticalDisksInfo(vzConnPtr privconn, PRL_HANDLE sdkdom, virDomain PrlHandle_Free(cdrom); cdrom = PRL_INVALID_HANDLE; - if (VIR_APPEND_ELEMENT(def->disks, def->ndisks, disk) < 0) + if (virDomainDiskInsert(def, disk) < 0) goto error; }