From: Matthias Bolte <matthias.bolte@googlemail.com>
Date: Tue, 2 Mar 2010 22:15:00 +0000 (+0100)
Subject: esx: Fix potential memory leak in esxVI_BuildFullTraversalSpecItem
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=bba36f7fc70edb3982affcc9e74b70de3dc9e248;p=libvirt.git

esx: Fix potential memory leak in esxVI_BuildFullTraversalSpecItem

If esxVI_String_DeepCopyValue or esxVI_SelectionSpec_AppendToList fail
then selectionSpec would leak. Add a free call in the failure path to
fix the leak.
---

diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
index aa46532740..63ddaa4301 100644
--- a/src/esx/esx_vi.c
+++ b/src/esx/esx_vi.c
@@ -1163,8 +1163,6 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList,
         currentSelectSetName = selectSetNames;
 
         while (currentSelectSetName != NULL && *currentSelectSetName != '\0') {
-            selectionSpec = NULL;
-
             if (esxVI_SelectionSpec_Alloc(&selectionSpec) < 0 ||
                 esxVI_String_DeepCopyValue(&selectionSpec->name,
                                            currentSelectSetName) < 0 ||
@@ -1173,6 +1171,7 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList,
                 goto failure;
             }
 
+            selectionSpec = NULL;
             currentSelectSetName += strlen(currentSelectSetName) + 1;
         }
     }
@@ -1186,6 +1185,7 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList,
 
   failure:
     esxVI_TraversalSpec_Free(&traversalSpec);
+    esxVI_SelectionSpec_Free(&selectionSpec);
 
     return -1;
 }