From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Thu, 6 Sep 2012 16:05:30 +0000 (+0100)
Subject: Disable qemu monitor by default.  The qemu monitor is an overly
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=bacc0d302445c75f18f4c826750fb5853b60e7ca;p=people%2Fandrewcoop%2Fqemu-traditional.git

Disable qemu monitor by default.  The qemu monitor is an overly
powerful feature which must be protected from untrusted (guest)
administrators.

Neither xl nor xend expect qemu to produce this monitor unless it is
explicitly requested.

This is a security problem, XSA-19.  Previously it was CVE-2007-0998
in Red Hat but we haven't dealt with it in upstream.  We hope to have
a new CVE for it here but we don't have one yet.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---

diff --git a/vl.c b/vl.c
index d30cb2c0..d21c3aa0 100644
--- a/vl.c
+++ b/vl.c
@@ -4920,7 +4920,7 @@ int main(int argc, char **argv, char **envp)
     kernel_cmdline = "";
     cyls = heads = secs = 0;
     translation = BIOS_ATA_TRANSLATION_AUTO;
-    monitor_device = "vc:80Cx24C";
+    monitor_device = "null";
 
     serial_devices[0] = "vc:80Cx24C";
     for(i = 1; i < MAX_SERIAL_PORTS; i++)