From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Sat, 22 Oct 2016 09:52:42 +0000 (+0300)
Subject: char: remove use-after-free on win-stdio
X-Git-Tag: qemu-xen-4.9.0-rc1~126^2~29
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=ba60e727b0a824baa1762264be5ef67dc30a6bac;p=qemu-xen.git

char: remove use-after-free on win-stdio

Found by reviewing the code, win_stdio_close() is called by
qemu_chr_free() which then call qemu_chr_free_common() taking care of
freeing CharDriverState*.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20161022095318.17775-3-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/qemu-char.c b/qemu-char.c
index d83a89618e..9165051f2a 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2435,7 +2435,6 @@ static void win_stdio_close(CharDriverState *chr)
     }
 
     g_free(chr->opaque);
-    g_free(chr);
 }
 
 static CharDriverState *qemu_chr_open_stdio(const char *id,