From: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Date: Wed, 4 Apr 2018 11:55:48 +0000 (+0200)
Subject: target-microblaze: dec_store: Use bool instead of unsigned int
X-Git-Tag: qemu-xen-4.12.0-rc1~205^2~36
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=b51b3d43deeb9880b383603806daedf125ae9cce;p=qemu-xen.git

target-microblaze: dec_store: Use bool instead of unsigned int

Use bool instead of unsigned int to represent flags.
Also, use extract32 instead of open coding the bit extract.

No functional change.

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---

diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index a8a5eaebec..413e683aec 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -1027,14 +1027,15 @@ static void dec_store(DisasContext *dc)
 {
     TCGv t, *addr, swx_addr;
     TCGLabel *swx_skip = NULL;
-    unsigned int size, rev = 0, ex = 0;
+    unsigned int size;
+    bool rev = false, ex = false;
     TCGMemOp mop;
 
     mop = dc->opcode & 3;
     size = 1 << mop;
     if (!dc->type_b) {
-        rev = (dc->ir >> 9) & 1;
-        ex = (dc->ir >> 10) & 1;
+        rev = extract32(dc->ir, 9, 1);
+        ex = extract32(dc->ir, 10, 1);
     }
     mop |= MO_TE;
     if (rev) {