From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Tue, 30 Jun 2009 14:22:14 +0000 (+0100)
Subject: cpu_unregister_map_client: fix memory leak
X-Git-Tag: xen-4.0.0-rc1~59
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=b471f03d51cde3976b6d52179ca2a86d8906a587;p=qemu-xen-4.0-testing.git

cpu_unregister_map_client: fix memory leak

fix memory leak in cpu_unregister_map_client() and cpu_notify_map_clients().

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

[ Picked out of qemu-devel submission for exec.c, because we have a
  clone-and-hack of the cpu_*map* code :-( -iwj ]
---

diff --git a/i386-dm/exec-dm.c b/i386-dm/exec-dm.c
index 45fc8e5a..b8af55a3 100644
--- a/i386-dm/exec-dm.c
+++ b/i386-dm/exec-dm.c
@@ -776,6 +776,7 @@ void cpu_unregister_map_client(void *_client)
     MapClient *client = (MapClient *)_client;
 
     LIST_REMOVE(client, link);
+    qemu_free(client);
 }
 
 static void cpu_notify_map_clients(void)
@@ -785,7 +786,7 @@ static void cpu_notify_map_clients(void)
     while (!LIST_EMPTY(&map_client_list)) {
         client = LIST_FIRST(&map_client_list);
         client->callback(client->opaque);
-        LIST_REMOVE(client, link);
+        cpu_unregister_map_client(client);
     }
 }