From: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Thu, 11 Feb 2021 17:44:36 +0000 (+0000)
Subject: tools/libxl: Fix uninitialised variable in libxl__write_stub_dmargs()
X-Git-Tag: 4.15.0-rc1~43
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=b4159d2de0153eb8ce6aced1978e1917c07cf39d;p=xen.git

tools/libxl: Fix uninitialised variable in libxl__write_stub_dmargs()

Various version of gcc, when compiling with -Og, complain:

  libxl_dm.c: In function ‘libxl__write_stub_dmargs’:
  libxl_dm.c:2166:16: error: ‘dmargs’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
               rc = libxl__xs_write_checked(gc, t, path, dmargs);
               ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

It isn't actually used while uninitialised, but only because of how the
is_linux_stubdom checks line up.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
---

diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c
index 291dee9b3f..db4cec6a76 100644
--- a/tools/libs/light/libxl_dm.c
+++ b/tools/libs/light/libxl_dm.c
@@ -2101,7 +2101,7 @@ static int libxl__write_stub_dmargs(libxl__gc *gc,
 {
     struct xs_permissions roperm[2];
     xs_transaction_t t = XBT_NULL;
-    char *dmargs;
+    char *dmargs = NULL;
     int rc;
 
     roperm[0].id = 0;