From: Akash Chandrashekar <akash.chandrashekar@citrix.com>
Date: Wed, 18 Nov 2015 11:10:00 +0000 (+0530)
Subject: Removing VBD destroy from removeCD() method and also to only eject CD in  the method... 
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=b387d6b59df43ef805af4208fc98428a1b68243e;p=xenrt-citrix%2Fxenrt.git

Removing VBD destroy from removeCD() method and also to only eject CD in  the method if CD is inserted
---

diff --git a/exec/xenrt/lib/xenserver/guest.py b/exec/xenrt/lib/xenserver/guest.py
index 4beb4629d..997c52551 100755
--- a/exec/xenrt/lib/xenserver/guest.py
+++ b/exec/xenrt/lib/xenserver/guest.py
@@ -2083,7 +2083,7 @@ exit /B 1
                 # See if we already have a CD device (insert or <EMPTY>), don;t
                 # care
                 empty = self.getHost().parseListForOtherParam("vbd-list",
-                                                              "device", 
+                                                              "device",
                                                               device,
                                                               "empty",
                                                               "vm-uuid=%s" %
@@ -2117,26 +2117,16 @@ exit /B 1
     def removeCD(self, device=None):
         """Remove the CD device from the VM."""
         cli = self.getCLIInstance()
-        if device:
-            vbds = self.getHost().minimalList("vbd-list",
-                                              "uuid",
-                                              "vm-uuid=%s type=CD device=%s" %
-                                              (self.getUUID(), device))
-        else:
-            vbds = self.getHost().minimalList("vbd-list",
-                                              "uuid",
-                                              "vm-uuid=%s type=CD" %
-                                              (self.getUUID()))
-        try:
-            args = []
-            args.append("uuid=%s" % (self.getUUID()))
-            cli.execute("vm-cd-eject", string.join(args))
-        except:
-            pass
-        for vbd in vbds:
-            args = []
-            args.append("uuid=%s" % (vbd))
-            cli.execute("vbd-destroy", string.join(args))
+        
+        cdvbds = self.getHost().minimalList("vbd-list","empty","vm-uuid=%s type=CD" % (self.getUUID()))
+        if cdvbds:
+            if cdvbds[0] == "false":
+                args = []
+                args.append("uuid=%s" % (self.getUUID()))
+                cli.execute("vm-cd-eject", string.join(args))
+        
+       
+        
 
     def createVIF(self, eth=None, bridge=None, mac=None, plug=False):
         if bridge:
@@ -4120,14 +4110,8 @@ exit /B 1
         self.enlightenedDrivers=True
         self.execguest("umount /mnt")
         xenrt.sleep(10)
-        try:
-            self.removeCD(device=device)
-        except xenrt.XRTFailure as e:
-            # In case of Linux on HVM, vbd-destroy on CD may fail.
-            if "vbd-destroy" in e.reason:
-                pass
-            else:
-                raise
+        self.removeCD(device=device)
+        
         if reboot or ((self.distro and (self.distro.startswith("centos4") or self.distro.startswith("rhel4"))) and updateKernel):
             # RHEL/CentOS 4.x update the kernel, so need to be rebooted
             self.reboot()