From: balrog <balrog@c046a42c-6fe2-441c-8c8c-71466251a162>
Date: Mon, 14 Jan 2008 03:48:37 +0000 (+0000)
Subject: Add a path length check to prevent heap overflow (Eric Milliken).
X-Git-Tag: xen-3.3.0-rc1~444
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=b34d259a81500d75e4cf435f1e8b262ba7e1421a;p=qemu-xen-4.0-testing.git

Add a path length check to prevent heap overflow (Eric Milliken).


git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3916 c046a42c-6fe2-441c-8c8c-71466251a162
---

diff --git a/block-vmdk.c b/block-vmdk.c
index af979a1e..9b5fb734 100644
--- a/block-vmdk.c
+++ b/block-vmdk.c
@@ -341,6 +341,8 @@ static int vmdk_parent_open(BlockDriverState *bs, const char * filename)
         p_name += sizeof("parentFileNameHint") + 1;
         if ((end_name = strchr(p_name,'\"')) == 0)
             return -1;
+        if ((end_name - p_name) > sizeof (s->hd->backing_file) - 1)
+            return -1;
 
         strncpy(s->hd->backing_file, p_name, end_name - p_name);
         if (stat(s->hd->backing_file, &file_buf) != 0) {