From: Paolo Bonzini Date: Thu, 18 Oct 2018 12:35:23 +0000 (+0200) Subject: target-i386: kvm: do not initialize padding fields X-Git-Tag: qemu-xen-4.13.0-rc1~614^2~42 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=b31c003895b030bea1319037d6bec976d47d9020;p=qemu-xen.git target-i386: kvm: do not initialize padding fields The exception.pad field is going to be renamed to pending in an upcoming header file update. Remove the unnecessary initialization; it was introduced to please valgrind (commit 7e680753cfa2) but they were later rendered unnecessary by commit 076796f8fd27f4d, which added the "= {}" initializer to the declaration of "events". Therefore the patch does not change behavior in any way. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- diff --git a/target/i386/kvm.c b/target/i386/kvm.c index dc4047b02f..302f420064 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -2686,7 +2686,6 @@ static int kvm_put_vcpu_events(X86CPU *cpu, int level) events.exception.nr = env->exception_injected; events.exception.has_error_code = env->has_error_code; events.exception.error_code = env->error_code; - events.exception.pad = 0; events.interrupt.injected = (env->interrupt_injected >= 0); events.interrupt.nr = env->interrupt_injected; @@ -2695,7 +2694,6 @@ static int kvm_put_vcpu_events(X86CPU *cpu, int level) events.nmi.injected = env->nmi_injected; events.nmi.pending = env->nmi_pending; events.nmi.masked = !!(env->hflags2 & HF2_NMI_MASK); - events.nmi.pad = 0; events.sipi_vector = env->sipi_vector; events.flags = 0;