From: Jiri Denemark <jdenemar@redhat.com>
Date: Tue, 5 Oct 2010 11:39:37 +0000 (+0200)
Subject: xen: Fix bogus error when attaching a device
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=ad4cb9056a173f057553403b17836859fd33b408;p=libvirt.git

xen: Fix bogus error when attaching a device

The xm internal xen driver only supports disk and network devices to be
added to a guest. On an attempt to attach any other device the xm driver
used VIR_ERR_XML_ERROR which resulted in a completely bogus error
message:

error: Failed to attach device from pci.xml
error: XML description for unknown device is not well formed or invalid
---

diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c
index b9cb4c337e..4c62072bd8 100644
--- a/src/xen/xm_internal.c
+++ b/src/xen/xm_internal.c
@@ -2975,8 +2975,8 @@ xenXMDomainAttachDeviceFlags(virDomainPtr domain, const char *xml,
     }
 
     default:
-        xenXMError(VIR_ERR_XML_ERROR,
-                   "%s", _("unknown device"));
+        xenXMError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                   _("Xm driver only supports adding disk or network devices"));
         goto cleanup;
     }