From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Wed, 30 Aug 2023 22:48:01 +0000 (-0400)
Subject: io: check there are no qio_channel_yield() coroutines during ->finalize()
X-Git-Tag: qemu-xen-4.20.0~553^2~9
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=acd4be64b865e81094c690503b4f39804eb67a0b;p=qemu-xen.git

io: check there are no qio_channel_yield() coroutines during ->finalize()

Callers must clean up their coroutines before calling
object_unref(OBJECT(ioc)) to prevent an fd handler leak. Add an
assertion to check this.

This patch is preparation for the fd handler changes that follow.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-ID: <20230830224802.493686-4-stefanha@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---

diff --git a/io/channel.c b/io/channel.c
index 72f0066af5..c415f3fc88 100644
--- a/io/channel.c
+++ b/io/channel.c
@@ -653,6 +653,10 @@ static void qio_channel_finalize(Object *obj)
 {
     QIOChannel *ioc = QIO_CHANNEL(obj);
 
+    /* Must not have coroutines in qio_channel_yield() */
+    assert(!ioc->read_coroutine);
+    assert(!ioc->write_coroutine);
+
     g_free(ioc->name);
 
 #ifdef _WIN32