From: Daniel P. Berrange <berrange@redhat.com>
Date: Wed, 22 Jun 2011 16:33:10 +0000 (+0100)
Subject: Fix use-after-free in handling domain taint flags
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=abb82f53ed6ba3b5f6c3e5453926859c680b39c9;p=libvirt.git

Fix use-after-free in handling domain taint flags

* src/conf/domain_conf.c: Fix use after free
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 11d54ade86..3d290fbe30 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6731,12 +6731,13 @@ static virDomainObjPtr virDomainObjParseXML(virCapsPtr caps,
         char *str = virXMLPropString(nodes[i], "flag");
         if (str) {
             int flag = virDomainTaintTypeFromString(str);
-            VIR_FREE(str);
             if (flag < 0) {
                 virDomainReportError(VIR_ERR_INTERNAL_ERROR,
                                      _("Unknown taint flag %s"), str);
+                VIR_FREE(str);
                 goto error;
             }
+            VIR_FREE(str);
             virDomainObjTaint(obj, flag);
         }
     }