From: Simon Arlott <bugzilla.redhat.simon@arlott.org>
Date: Fri, 8 Apr 2016 13:01:33 +0000 (-0400)
Subject: virt-aa-helper: disallow VNC socket read permissions
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=ab9569e5460d1e4737fe8b625c67687dc2204665;p=libvirt.git

virt-aa-helper: disallow VNC socket read permissions

The VM does not need read permission for its own VNC socket to create(),
bind(), accept() connections or to receive(), send(), etc. on connections.

https://bugzilla.redhat.com/show_bug.cgi?id=1312573
---

diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
index 5db9c02abb..7eeb4eff6d 100644
--- a/src/security/virt-aa-helper.c
+++ b/src/security/virt-aa-helper.c
@@ -1062,7 +1062,7 @@ get_files(vahControl * ctl)
     for (i = 0; i < ctl->def->ngraphics; i++) {
         if (ctl->def->graphics[i]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC &&
             ctl->def->graphics[i]->data.vnc.socket &&
-            vah_add_file(&buf, ctl->def->graphics[i]->data.vnc.socket, "rw"))
+            vah_add_file(&buf, ctl->def->graphics[i]->data.vnc.socket, "w"))
             goto cleanup;
     }