From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 1 Oct 2019 05:22:14 +0000 (+0200)
Subject: conf: checkpoint: Don't clear current checkpoint when redefining an existing one
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=a8f92d2d7f09f53619f55efdac2b93c70f337f4e;p=libvirt.git

conf: checkpoint: Don't clear current checkpoint when redefining an existing one

There's no point in clearing the current checkpoint when we are just
changing the definition of the current checkpoint as by the virtue of the
'update_current' flag the same checkpoint would become current in
qemuCheckpointCreateXML.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/checkpoint_conf.c b/src/conf/checkpoint_conf.c
index 62ec9ced41..71eac76a15 100644
--- a/src/conf/checkpoint_conf.c
+++ b/src/conf/checkpoint_conf.c
@@ -569,11 +569,6 @@ virDomainCheckpointRedefinePrep(virDomainObjPtr vm,
                                            def->parent.dom, xmlopt))
             return -1;
 
-        if (other == virDomainCheckpointGetCurrent(vm->checkpoints)) {
-            *update_current = true;
-            virDomainCheckpointSetCurrent(vm->checkpoints, NULL);
-        }
-
         /* Drop and rebuild the parent relationship, but keep all
          * child relations by reusing chk.  */
         virDomainMomentDropParent(other);