From: Sascha Silbe Date: Wed, 27 Jul 2016 14:05:20 +0000 (+0200) Subject: qemu: fix domain id after domainCreateWithFlags() X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=a5c420471b6de6afa001eb27ef2e4e66a022a381;p=libvirt.git qemu: fix domain id after domainCreateWithFlags() Ever since virDomainCreateWithFlags() was introduced by de3aadaa [drivers: add virDomainCreateWithFlags if virDomainCreate exists], the domain ID retrieved with virDomainGetID() was incorrect for several drivers after virDomainCreateWithFlags() was called. The API consumer had to look up the domain anew to retrieve the correct ID. For the ESX driver, this was fixed in 6139b274 [esx: Update ID after starting a domain]. For the openvz driver, it was fixed in fd81a097 [openvzDomainCreateWithFlags: set domain id to the correct value]. The test driver, the OpenNebula driver (removed in the meantime) and the vbox driver were already updating the domain ID correctly in domainCreate(). Copy over the ID in qemuDomainCreateWithFlags() to fix this for the qemu driver, too. Fixes: de3aadaa ("drivers: add virDomainCreateWithFlags if virDomainCreate exists") Reported-by: Marc Hartmayer Signed-off-by: Sascha Silbe Tested-by: Marc Hartmayer Reviewed-by: Marc Hartmayer --- diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b47ef41653..abb777ac1c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7100,6 +7100,7 @@ qemuDomainCreateWithFlags(virDomainPtr dom, unsigned int flags) QEMU_ASYNC_JOB_START) < 0) goto endjob; + dom->id = vm->def->id; ret = 0; endjob: