From: Roman Bogorodskiy <bogorodskiy@gmail.com>
Date: Thu, 4 Feb 2021 15:29:44 +0000 (+0400)
Subject: bhyve: drop emulator binary value check
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=a58edc602ebfef9323d405f846cb0076bdfc8044;p=libvirt.git

bhyve: drop emulator binary value check

Currently, requesting domain capabilities fails when the specified
emulator binary does not equal to "/usr/sbin/bhyve". As we're
not using user-specified emulator anyway, drop this check to avoid
showing errors for values like "bhyve" (without absolute path).

Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 78c3241293..d02dc65a9d 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -1645,14 +1645,8 @@ bhyveConnectGetDomainCapabilities(virConnectPtr conn,
         goto cleanup;
     }
 
-    if (emulatorbin == NULL) {
+    if (emulatorbin == NULL)
         emulatorbin = "/usr/sbin/bhyve";
-    } else if (STRNEQ(emulatorbin, "/usr/sbin/bhyve")) {
-        virReportError(VIR_ERR_INVALID_ARG,
-                       _("unknown emulator binary: %s"),
-                       emulatorbin);
-        goto cleanup;
-    }
 
     if (!(caps = virBhyveDomainCapsBuild(conn->privateData, emulatorbin,
                                          machine, arch, virttype)))