From: Juan Quintela Date: Wed, 9 Oct 2013 10:30:35 +0000 (+0200) Subject: memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations X-Git-Tag: qemu-xen-4.5.0-rc1~264^2~11 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=a461e389f489e72cdc770ff887512c2c9109bc43;p=qemu-xen.git memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations We were clearing a range of bits, so use bitmap_clear(). Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 4906cdf0ea..e2f55eaeb1 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -95,14 +95,12 @@ static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start, ram_addr_t length, unsigned client) { - ram_addr_t addr, end; + unsigned long end, page; assert(client < DIRTY_MEMORY_NUM); - end = TARGET_PAGE_ALIGN(start + length); - start &= TARGET_PAGE_MASK; - for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { - clear_bit(addr >> TARGET_PAGE_BITS, ram_list.dirty_memory[client]); - } + end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS; + page = start >> TARGET_PAGE_BITS; + bitmap_clear(ram_list.dirty_memory[client], page, end - page); } void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t end,