From: Ján Tomko <jtomko@redhat.com>
Date: Tue, 14 Jun 2016 16:30:30 +0000 (+0200)
Subject: check-spacing: simplify keyword spacing check
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=a2762b93fd5a8240f3e326e3ae9af07b09866cb9;p=libvirt.git

check-spacing: simplify keyword spacing check

We do not need a separate check forbidding whitespace
after the opening parenthesis after a keyword -
we forbid it after all of them.

The only allowed whitespace after an opening parenthesis
is a newline, tune the regex to reflect that.
---

diff --git a/build-aux/check-spacing.pl b/build-aux/check-spacing.pl
index 7c5bbf9e51..a0fb1109de 100755
--- a/build-aux/check-spacing.pl
+++ b/build-aux/check-spacing.pl
@@ -101,10 +101,8 @@ foreach my $file (@ARGV) {
             }
         }
 
-        # Require whitespace immediately after keywords,
-        # but none after the opening bracket
-        if ($data =~ /\b(if|for|while|switch|return)\(/ ||
-            $data =~ /\b(if|for|while|switch|return)\s+\(\s/) {
+        # Require whitespace immediately after keywords
+        if ($data =~ /\b(if|for|while|switch|return)\(/) {
             print "No whitespace after keyword:\n";
             print "$file:$.: $line";
             $ret = 1;
@@ -121,7 +119,7 @@ foreach my $file (@ARGV) {
         # but allow whitespace before ) on a single line
         # (optionally followed by a semicolon)
         if (($data =~ /\s\)/ && not $data =~ /^\s+\);?$/) ||
-            $data =~ /\(\s+\S/) {
+            $data =~ /\((?!$)\s/) {
             print "Whitespace after '(' or before ')':\n";
             print "$file:$.: $line";
             $ret = 1;