From: Max Reitz Date: Wed, 22 May 2019 17:03:48 +0000 (+0200) Subject: block/commit: Drop bdrv_child_try_set_perm() X-Git-Tag: qemu-xen-4.13.0-rc1~114^2~5 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=a193ad3b3b27eec6914bd3cd7dc4bff02f59177f;p=qemu-xen.git block/commit: Drop bdrv_child_try_set_perm() commit_top_bs never requests or unshares any permissions. There is no reason to make this so explicit here. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- diff --git a/block/commit.c b/block/commit.c index c815def89a..212c6f639e 100644 --- a/block/commit.c +++ b/block/commit.c @@ -110,8 +110,6 @@ static void commit_abort(Job *job) * XXX Can (or should) we somehow keep 'consistent read' blocked even * after the failed/cancelled commit job is gone? If we already wrote * something to base, the intermediate images aren't valid any more. */ - bdrv_child_try_set_perm(s->commit_top_bs->backing, 0, BLK_PERM_ALL, - &error_abort); bdrv_replace_node(s->commit_top_bs, backing_bs(s->commit_top_bs), &error_abort);