From: Owen Smith <owen.smith@cloud.com>
Date: Fri, 29 Sep 2023 07:39:57 +0000 (+0100)
Subject: Remove CoInstaller from INF
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=9fac54b9f6961249f6c73c3e7e8f208c3c7b0abe;p=pvdrivers%2Fwin%2Fxennet.git

Remove CoInstaller from INF

Windows 11 22H2 WHQL requires INF files pass "InfVerif /k", which highlights
several issues
- PnpLockdown=1 needs to be specified
- CoInstallers are no longer allowed

The CoInstaller has several functions that will need alternative solutions:
- The AllowUpdate mechanism is no longer possible
- The safety checks that ensure interface versionings remain compatible

Interface safety checks need to be handled by changes to child device bindings,
and assuming upgrade via emulated devices is safe. The unplug key is cleared
in the INF to revert to emulated NICs on the next boot, incase the current child
drivers rely on an interface that is no longer present (note: in this case,
child drivers will need updating).

Signed-off-by: Owen Smith <owen.smith@cloud.com>
---

diff --git a/src/xennet.inf b/src/xennet.inf
index 27cb2e2..b1d1105 100644
--- a/src/xennet.inf
+++ b/src/xennet.inf
@@ -37,24 +37,20 @@ Provider=%Vendor%
 CatalogFile=xennet.cat
 DriverVer=@INF_DATE@,@MAJOR_VERSION@.@MINOR_VERSION@.@MICRO_VERSION@.@BUILD_NUMBER@
 DriverPackageDisplayName=%DiskDesc%
+PnpLockdown=1
 
 [DestinationDirs] 
 DefaultDestDir=12 
-CoInst_CopyFiles=11
 
 [SourceDisksNames]
 0=%DiskDesc%
 
 [SourceDisksFiles]
 xennet.sys=0,,
-xennet_coinst.dll=0,,
 
 [XenNet_Copyfiles]
 xennet.sys
 
-[CoInst_CopyFiles]
-xennet_coinst_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.dll,xennet_coinst.dll
-
 [Manufacturer] 
 %Vendor%=Inst,NT@INF_ARCH@
 
@@ -195,13 +191,6 @@ AddReg=XenNet_EventLog_AddReg
 HKR,,EventMessageFile,0x00020000,"%%SystemRoot%%\System32\netevent.dll"
 HKR,,TypesSupported,0x00010001,7
 
-[XenNet_Inst.CoInstallers]
-CopyFiles=CoInst_CopyFiles
-AddReg=CoInst_AddReg
-
-[CoInst_AddReg]
-HKR,,CoInstallers32,0x00010000,"xennet_coinst_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.dll,Entry"
-
 [Strings] 
 
 Vendor="@VENDOR_NAME@"