From: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Date: Wed, 13 Dec 2017 19:15:49 +0000 (+0100)
Subject: xenconfig: fix issue found by coverity in multiple IP support
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=9f8778dfca0a92572d9c00b0ed73b65a18a556d5;p=libvirt.git

xenconfig: fix issue found by coverity in multiple IP support

virStringSplit may return NULL, so we must handle that.

Cc: John Ferlan <jferlan@redhat.com>
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---

diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c
index 9777d23475..ca3b4dee6a 100644
--- a/src/xenconfig/xen_common.c
+++ b/src/xenconfig/xen_common.c
@@ -968,6 +968,9 @@ xenParseVif(virConfPtr conf, virDomainDefPtr def, const char *vif_typename)
                 char **ip_list = virStringSplit(ip, " ", 0);
                 size_t i;
 
+                if (!ip_list)
+                    goto cleanup;
+
                 for (i = 0; ip_list[i]; i++) {
                     if (virDomainNetAppendIPAddress(net, ip_list[i], 0, 0) < 0) {
                         virStringListFree(ip_list);