From: Martin Kletzander <mkletzan@redhat.com>
Date: Thu, 9 Jul 2020 07:27:41 +0000 (+0200)
Subject: resctrl: Do not open directory for writing
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=9d832813820b948eb508508fb3cbd86c90698119;p=libvirt.git

resctrl: Do not open directory for writing

When preparing for the removal of GNULIB commit 18dca21a32e9 removed the
unneeded O_DIRECTORY, but unfortunately started opening the directory for
writing which fails every time for a directory.  There is also no need for that
as flock() works on O_RDONLY file descriptor as well, even for LOCK_EX.

https://bugzilla.redhat.com/1852741

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
---

diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index e44f2ff30c..3563fc560d 100644
--- a/src/util/virresctrl.c
+++ b/src/util/virresctrl.c
@@ -456,7 +456,7 @@ VIR_ONCE_GLOBAL_INIT(virResctrl);
 static int
 virResctrlLockWrite(void)
 {
-    int fd = open(SYSFS_RESCTRL_PATH, O_RDWR | O_CLOEXEC);
+    int fd = open(SYSFS_RESCTRL_PATH, O_RDONLY | O_CLOEXEC);
 
     if (fd < 0) {
         virReportSystemError(errno, "%s", _("Cannot open resctrl"));