From: Stefan Bader <stefan.bader@canonical.com>
Date: Wed, 31 Jul 2013 09:59:21 +0000 (+0200)
Subject: xen: Avoid double free of virDomainDef in xenDaemonCreateXML
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=9d0557b9655fe4a3f31af2e1cc2f33de8acfaa7d;p=libvirt.git

xen: Avoid double free of virDomainDef in xenDaemonCreateXML

The virDomainDef is allocated by the caller and also used after
calling to xenDaemonCreateXML. So it must not get freed by the
callee.

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---

diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
index 9d61fcadc6..1ce36e6967 100644
--- a/src/xen/xend_internal.c
+++ b/src/xen/xend_internal.c
@@ -2171,7 +2171,6 @@ xenDaemonCreateXML(virConnectPtr conn, virDomainDefPtr def)
     if (xenDaemonDomainResume(conn, def) < 0)
         goto error;
 
-    virDomainDefFree(def);
     return 0;
 
   error: