From: Alex Chen <alex.chen@huawei.com>
Date: Tue, 10 Nov 2020 19:23:08 +0000 (+0000)
Subject: plugins: Fix two resource leaks in setup_socket()
X-Git-Tag: qemu-xen-4.16.0-rc4~486^2~7
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=9cd7dde0730ed823b545910c0d5a676142015e3b;p=qemu-xen.git

plugins: Fix two resource leaks in setup_socket()

Either accept() fails or exits normally, we need to close the fd.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20201109082829.87496-3-alex.chen@huawei.com>
Message-Id: <20201110192316.26397-3-alex.bennee@linaro.org>
---

diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 319bd44b83..5aad50869d 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -268,11 +268,13 @@ static bool setup_socket(const char *path)
     socket_fd = accept(fd, NULL, NULL);
     if (socket_fd < 0 && errno != EINTR) {
         perror("accept socket");
+        close(fd);
         return false;
     }
 
     qemu_plugin_outs("setup_socket::ready\n");
 
+    close(fd);
     return true;
 }