From: Daniel P. Berrange <berrange@redhat.com>
Date: Tue, 8 Apr 2014 14:43:45 +0000 (+0100)
Subject: Fix leak on OOM in virNWFilterVarValueCreateSimpleCopyValue
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=9b095625e4d983e6ed3b633a170ca5ff95c67c41;p=libvirt.git

Fix leak on OOM in virNWFilterVarValueCreateSimpleCopyValue

If virNWFilterVarValueCreateSimple fails with OOM, then
'val' will be leaked by virNWFilterVarValueCreateSimpleCopyValue

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c
index 40eccc4930..3e85bc1623 100644
--- a/src/conf/nwfilter_params.c
+++ b/src/conf/nwfilter_params.c
@@ -126,10 +126,14 @@ virNWFilterVarValuePtr
 virNWFilterVarValueCreateSimpleCopyValue(const char *value)
 {
     char *val;
+    virNWFilterVarValuePtr ret;
 
     if (VIR_STRDUP(val, value) < 0)
         return NULL;
-    return virNWFilterVarValueCreateSimple(val);
+    ret = virNWFilterVarValueCreateSimple(val);
+    if (!ret)
+        VIR_FREE(val);
+    return ret;
 }
 
 const char *