From: Amadeusz Sławiński Date: Thu, 21 Feb 2013 07:34:11 +0000 (+0000) Subject: PPC: xnu kernel expects FLUSH to be cleared on STOP X-Git-Tag: qemu-xen-4.4.0-rc1~6^2~925^2~5^2~5 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=987422bc4a4c6366ca6a7fbfa38a9920fd7ada2f;p=qemu-upstream-4.4-testing.git PPC: xnu kernel expects FLUSH to be cleared on STOP otherwise it gets stuck in a loop so clear it when unsetting run when flush is set void IODBDMAStop( volatile IODBDMAChannelRegisters *registers) { IOSetDBDMAChannelControl( registers, IOClearDBDMAChannelControlBits( kdbdmaRun ) | IOSetDBDMAChannelControlBits( kdbdmaFlush )); DBDMA: writel 0x0000000000000b00 <= 0xa0002000 DBDMA: channel 0x16 reg 0x0 DBDMA: status 0x00002000 while( IOGetDBDMAChannelStatus( registers) & ( kdbdmaActive | kdbdmaFlush)) eieio(); DBDMA: readl 0x0000000000000b04 => 0x00002000 DBDMA: channel 0x16 reg 0x1 DBDMA: readl 0x0000000000000b04 => 0x00002000 DBDMA: channel 0x16 reg 0x1 DBDMA: readl 0x0000000000000b04 => 0x00002000 DBDMA: channel 0x16 reg 0x1 DBDMA: readl 0x0000000000000b04 => 0x00002000 DBDMA: channel 0x16 reg 0x1 it continues to get printed } Signed-off-by: Amadeusz Sławiński [agraf: replace tabs with spaces] Signed-off-by: Alexander Graf --- diff --git a/hw/mac_dbdma.c b/hw/mac_dbdma.c index b894ab21a..73d74c2c5 100644 --- a/hw/mac_dbdma.c +++ b/hw/mac_dbdma.c @@ -688,6 +688,10 @@ dbdma_control_write(DBDMA_channel *ch) if ((ch->regs[DBDMA_STATUS] & RUN) && !(status & RUN)) { /* RUN is cleared */ status &= ~(ACTIVE|DEAD); + if ((status & FLUSH) && ch->flush) { + ch->flush(&ch->io); + status &= ~FLUSH; + } } DBDMA_DPRINTF(" status 0x%08x\n", status);