From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 28 May 2014 09:17:03 +0000 (+0200)
Subject: block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR
X-Git-Tag: qemu-xen-4.5.0-rc1^2~61
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=98646a11d0977b99bd05efbd6bf8330411ebba63;p=qemu-upstream-4.5-testing.git

block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR

Introduced in commit a8d8ecb.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit f25391c2a6ef1674384204265429520ea50e82bc)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---

diff --git a/block/qapi.c b/block/qapi.c
index 8f2b4dbe7..a69c00d4b 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -474,6 +474,7 @@ static void dump_qobject(fprintf_function func_fprintf, void *f,
         case QTYPE_QERROR: {
             QString *value = qerror_human((QError *)obj);
             func_fprintf(f, "%s", qstring_get_str(value));
+            QDECREF(value);
             break;
         }
         case QTYPE_NONE: