From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 11 Jan 2016 11:48:30 +0000 (+0100)
Subject: virDomainInterfaceAddresses: Allow API on RO connection too
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=95c370f0eead8ab0bedf333d54019f55aa001116;p=libvirt.git

virDomainInterfaceAddresses: Allow API on RO connection too

This API does not change domain state. However, we have a policy
that an API talking to a guest agent requires RW access. But that
happens only if source == VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 677a9ad8de..02fc4df45d 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -11546,7 +11546,8 @@ virDomainInterfaceAddresses(virDomainPtr dom,
         *ifaces = NULL;
     virCheckDomainReturn(dom, -1);
     virCheckNonNullArgGoto(ifaces, error);
-    virCheckReadOnlyGoto(dom->conn->flags, error);
+    if (source == VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT)
+        virCheckReadOnlyGoto(dom->conn->flags, error);
 
     if (dom->conn->driver->domainInterfaceAddresses) {
         int ret;