From: John Ferlan Date: Wed, 2 Mar 2016 00:36:37 +0000 (-0500) Subject: util: Fix missing initializer for agent X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=95aa1017951e410b6e1ebbc685034ac4cc49c6fb;p=libvirt.git util: Fix missing initializer for agent In virPolkitAgentCreate neglected to initialize agent to NULL. If there was an error in the pipe, then we jump to error and would have an issue. Found by coverity. --- diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 3d2be61bba..44f2328303 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -166,7 +166,7 @@ virPolkitAgentDestroy(virPolkitAgentPtr agent) virPolkitAgentPtr virPolkitAgentCreate(void) { - virPolkitAgentPtr agent; + virPolkitAgentPtr agent = NULL; virCommandPtr cmd = virCommandNewArgList(PKTTYAGENT, "--process", NULL); int pipe_fd[2] = {-1, -1}; struct pollfd pollfd;