From: Ján Tomko <jtomko@redhat.com>
Date: Thu, 14 Nov 2019 13:44:24 +0000 (+0100)
Subject: syntax-check: prefer g_mkstemp_full and g_mkdtemp
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=954f36e078d44ece7ee79a9cb099d8195a347275;p=libvirt.git

syntax-check: prefer g_mkstemp_full and g_mkdtemp

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 74d0d5f6d4..7d1ac4dbfc 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -402,10 +402,17 @@ sc_prohibit_fork_wrappers:
 	halt='use virCommand for child processes' \
 	  $(_sc_search_regexp)
 
-# Prefer mkostemp with O_CLOEXEC.
+# Prefer g_mkostemp_full with O_CLOEXEC.
 sc_prohibit_mkstemp:
-	@prohibit='[^"]\<mkstemps? *\(' \
-	halt='use mkostemp with O_CLOEXEC instead of mkstemp' \
+	@prohibit='[^"]\<mko?stemps? *\(' \
+	in_vc_files='\.[chx]$$' \
+	halt='use g_mkstemp_full with O_CLOEXEC instead of mkstemp' \
+	  $(_sc_search_regexp)
+
+sc_prohibit_mkdtemp:
+	@prohibit='[^"]\<mkdtemp *\(' \
+	in_vc_files='\.[chx]$$' \
+	halt='use g_mkdtemp instead of mkdtemp' \
 	  $(_sc_search_regexp)
 
 # access with X_OK accepts directories, but we can't exec() those.