From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 25 Sep 2014 15:12:46 +0000 (+0200)
Subject: virNodeAllocPages: Disallow RO connection
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=92b0577db269764dfbb2b5139647796315f73702;p=libvirt.git

virNodeAllocPages: Disallow RO connection

Due to a missing check the API can be successfully called even if
the connection is ReadOnly. Fortunately, the API hasn't been
released yet, so there's no need for a CVE.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/libvirt.c b/src/libvirt.c
index 388c040c6a..245c373bcc 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -21893,6 +21893,7 @@ virNodeAllocPages(virConnectPtr conn,
     virResetLastError();
 
     virCheckConnectReturn(conn, -1);
+    virCheckReadOnlyGoto(conn->flags, error);
     virCheckNonZeroArgGoto(npages, error);
     virCheckNonNullArgGoto(pageSizes, error);
     virCheckNonNullArgGoto(pageCounts, error);