From: John Snow Date: Tue, 21 Jul 2015 18:02:01 +0000 (-0400) Subject: ahci: fix ICC mask definition X-Git-Tag: qemu-xen-4.7.0-rc1~128^2 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=91ced514461e1a533bfb9e2eea32bd7df678b1cd;p=qemu-xen.git ahci: fix ICC mask definition There are likely others that could be updated, but we'll go with a light touch for 2.4 for now. Without the Unsigned specifier, this shifts bits into the signed bit, which makes clang unhappy and could cause unwanted behavior. Reported-by: Peter Maydell Signed-off-by: John Snow Message-id: 1437501721-24495-1-git-send-email-jsnow@redhat.com --- diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h index 68d5074b33..79a463d93c 100644 --- a/hw/ide/ahci.h +++ b/hw/ide/ahci.h @@ -127,7 +127,7 @@ #define PORT_CMD_SPIN_UP (1 << 1) /* Spin up device */ #define PORT_CMD_START (1 << 0) /* Enable port DMA engine */ -#define PORT_CMD_ICC_MASK (0xf << 28) /* i/f ICC state mask */ +#define PORT_CMD_ICC_MASK (0xfU << 28) /* i/f ICC state mask */ #define PORT_CMD_ICC_ACTIVE (0x1 << 28) /* Put i/f in active state */ #define PORT_CMD_ICC_PARTIAL (0x2 << 28) /* Put i/f in partial state */ #define PORT_CMD_ICC_SLUMBER (0x6 << 28) /* Put i/f in slumber state */