From: Matthew Booth <mbooth@redhat.com>
Date: Thu, 5 Nov 2009 16:56:08 +0000 (+0100)
Subject: Properly convert port numbers to/from network byte order
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=91b009cde46bb53e4d3285948966d1e8c278d10a;p=libvirt.git

Properly convert port numbers to/from network byte order

* src/util/network.c: Add htons and ntohs in virSocket(Get|Set)Port
---

diff --git a/src/util/network.c b/src/util/network.c
index d67340a6f5..56426e712f 100644
--- a/src/util/network.c
+++ b/src/util/network.c
@@ -173,6 +173,8 @@ virSocketSetPort(virSocketAddrPtr addr, int port) {
     if (addr == NULL)
         return -1;
 
+    port = htons(port);
+
     if(addr->stor.ss_family == AF_INET) {
         addr->inet4.sin_port = port;
     }
@@ -201,11 +203,11 @@ virSocketGetPort(virSocketAddrPtr addr) {
         return -1;
 
     if(addr->stor.ss_family == AF_INET) {
-        return addr->inet4.sin_port;
+        return ntohs(addr->inet4.sin_port);
     }
 
     else if(addr->stor.ss_family == AF_INET6) {
-        return addr->inet6.sin6_port;
+        return ntohs(addr->inet6.sin6_port);
     }
 
     return -1;