From: Alex Williamson <alex.williamson@redhat.com>
Date: Tue, 8 Jan 2013 21:10:03 +0000 (-0700)
Subject: vfio-pci: Loosen sanity checks to allow future features
X-Git-Tag: qemu-xen-4.4.0-rc1~6^2~1443^2
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=8fc94e5a8046e349e07976f9bcaffbcd5833f3a2;p=qemu-upstream-4.4-testing.git

vfio-pci: Loosen sanity checks to allow future features

VFIO_PCI_NUM_REGIONS and VFIO_PCI_NUM_IRQS should never have been
used in this manner as it locks a specific kernel implementation.
Future features may introduce new regions or interrupt entries
(VGA may add legacy ranges, AER might add an IRQ for error
signalling).  Fix this before it gets us into trouble.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-stable@nongnu.org
---

diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c
index 8ec1faf27..c51ae6761 100644
--- a/hw/vfio_pci.c
+++ b/hw/vfio_pci.c
@@ -1837,13 +1837,13 @@ static int vfio_get_device(VFIOGroup *group, const char *name, VFIODevice *vdev)
         error_report("Warning, device %s does not support reset\n", name);
     }
 
-    if (dev_info.num_regions != VFIO_PCI_NUM_REGIONS) {
+    if (dev_info.num_regions < VFIO_PCI_CONFIG_REGION_INDEX + 1) {
         error_report("vfio: unexpected number of io regions %u\n",
                      dev_info.num_regions);
         goto error;
     }
 
-    if (dev_info.num_irqs != VFIO_PCI_NUM_IRQS) {
+    if (dev_info.num_irqs < VFIO_PCI_MSIX_IRQ_INDEX + 1) {
         error_report("vfio: unexpected number of irqs %u\n", dev_info.num_irqs);
         goto error;
     }