From: Gonglei Date: Tue, 30 Sep 2014 06:10:37 +0000 (+0800) Subject: virtio-9p: fix virtio-9p child refcount in transports X-Git-Tag: qemu-xen-4.6.0-rc1~144^2~19 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=8f3d60e568f53cb3ccdedd917f8e49cdb304973b;p=qemu-upstream-unstable.git virtio-9p: fix virtio-9p child refcount in transports object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon unplug the virtio-9p child is not finalized! Drop our reference after the child property has been added to the parent. Signed-off-by: Gonglei Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 714286dab..8f3b79b03 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -950,6 +950,7 @@ static void virtio_9p_pci_instance_init(Object *obj) object_initialize(&dev->vdev, sizeof(dev->vdev), TYPE_VIRTIO_9P); object_property_add_child(obj, "virtio-backend", OBJECT(&dev->vdev), NULL); qdev_alias_all_properties(DEVICE(&dev->vdev), obj); + object_unref(OBJECT(&dev->vdev)); } static const TypeInfo virtio_9p_pci_info = {