From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Fri, 14 Oct 2016 14:37:11 +0000 (+0100)
Subject: support check: Style improvements - rename _check_for_command
X-Git-Tag: openstack-v11~210
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=8be1bf7ab1c327ce095cfff51a6d224407a83c1f;p=people%2Faperard%2Fosstest.git

support check: Style improvements - rename _check_for_command

Put an underscore in front.  This is not a public method.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---

diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm
index 2ee8b3c3..45df1734 100644
--- a/Osstest/Toolstack/libvirt.pm
+++ b/Osstest/Toolstack/libvirt.pm
@@ -99,7 +99,7 @@ sub migrate_check ($$) {
 	('/capabilities/host/migration_features/live');
 }
 
-sub check_for_command($$) {
+sub _check_for_command($$) {
     my ($self,$cmd) = @_;
     my $ho = $self->{Host};
     my $help = target_cmd_output_root($ho, "virsh help");
@@ -110,7 +110,7 @@ sub saverestore_check ($) {
     my ($self) = @_;
     return
 	_check_capability($self, '/capabilities/host/migration_features') &&
-	check_for_command($self, "save");
+	_check_for_command($self, "save");
 }
 
 sub migrate ($$$$) {
diff --git a/Osstest/Toolstack/xl.pm b/Osstest/Toolstack/xl.pm
index 6a4a5d79..e179217c 100644
--- a/Osstest/Toolstack/xl.pm
+++ b/Osstest/Toolstack/xl.pm
@@ -61,7 +61,7 @@ sub shutdown_wait ($$$) {
     target_cmd_root($ho,"$self->{_Command} shutdown -w${acpi_fallback} $gn", $timeout);
 }
 
-sub check_for_command($$) {
+sub _check_for_command($$) {
     my ($self,$cmd) = @_;
     my $ho = $self->{Host};
     my $help = target_cmd_output_root($ho, $self->{_Command}." help");
@@ -70,12 +70,12 @@ sub check_for_command($$) {
 
 sub migrate_check ($$) {
     my ($self,$local) = @_;
-    return check_for_command($self, "migrate");
+    return _check_for_command($self, "migrate");
 }
 
 sub saverestore_check ($) {
     my ($self) = @_;
-    return check_for_command($self, "save");
+    return _check_for_command($self, "save");
 }
 
 sub migrate ($$$$) {