From: balrog Date: Sun, 25 May 2008 00:14:34 +0000 (+0000) Subject: Invalidate VNC framebuffer on every resize. X-Git-Tag: qemu-xen-4.2.0~9834 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=8bba5c81b1febeb20cdd60f1c18eb0e695cad6d6;p=qemu-xen.git Invalidate VNC framebuffer on every resize. On a resize, vncviewer keeps the image in the upper-left part of the screen unmodified and fills the right end of the lines with black colour. vnc.c keeps the first n bytes of the framebuffer unmodified instead - meaning that the client's image doesn't match the image in framebuffer and checking for dirty rows gives wrong results. We can either invalidate the whole buffer or implement the same transformation as the client. git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4569 c046a42c-6fe2-441c-8c8c-71466251a162 --- diff --git a/vnc.c b/vnc.c index 4b578388c7..423544287a 100644 --- a/vnc.c +++ b/vnc.c @@ -316,6 +316,9 @@ static void vnc_dpy_resize(DisplayState *ds, int w, int h) vs->width = ds->width; vs->height = ds->height; } + + memset(vs->dirty_row, 0xFF, sizeof(vs->dirty_row)); + memset(vs->old_data, 42, vs->ds->linesize * vs->ds->height); } /* fastest code */ @@ -1182,8 +1185,6 @@ static void set_pixel_format(VncState *vs, } vnc_dpy_resize(vs->ds, vs->ds->width, vs->ds->height); - memset(vs->dirty_row, 0xFF, sizeof(vs->dirty_row)); - memset(vs->old_data, 42, vs->ds->linesize * vs->ds->height); vga_hw_invalidate(); vga_hw_update(); @@ -1982,8 +1983,6 @@ void vnc_display_init(DisplayState *ds) vs->ds->dpy_resize = vnc_dpy_resize; vs->ds->dpy_refresh = NULL; - memset(vs->dirty_row, 0xFF, sizeof(vs->dirty_row)); - vnc_dpy_resize(vs->ds, 640, 400); }